-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: fix CJS/ESM toggle on small screens #43506
Conversation
Fixes: nodejs#43468 Co-authored-by: Moshe Atlow <[email protected]>
Co-authored-by: Livia Medeiros <[email protected]>
Commit Queue failed- Loading data for nodejs/node/pull/43506 FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close at consumeBody (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60) at processTicksAndRejections (node:internal/process/task_queues:96:5) at async Response.text (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18) at async Request.json (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/request.js:51:18) at async Request.query (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/request.js:109:20) at async Request.queryAll (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/request.js:136:20) at async Request.gql (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/request.js:66:22) at async PRData.getComments (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21) at async Promise.all (index 2) at async Promise.all (index 1) { type: 'system', errno: 'ERR_STREAM_PREMATURE_CLOSE', code: 'ERR_STREAM_PREMATURE_CLOSE', erroredSysCall: undefined }https://github.com/nodejs/node/actions/runs/2570249122 |
Commit Queue failed- Loading data for nodejs/node/pull/43506 ✔ Done loading data for nodejs/node/pull/43506 ----------------------------------- PR info ------------------------------------ Title tools: fix CJS/ESM toggle on small screens (#43506) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:cjs-esm-toggle-small-screens -> nodejs:main Labels doc, tools, author ready Commits 4 - tools: fix CJS/ESM toggle on small screens - fixup! tools: fix CJS/ESM toggle on small screens - fixup! tools: fix CJS/ESM toggle on small screens - fixup! tools: fix CJS/ESM toggle on small screens Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/43506 Fixes: https://github.com/nodejs/node/issues/43468 Reviewed-By: LiviaMedeiros ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43506 Fixes: https://github.com/nodejs/node/issues/43468 Reviewed-By: LiviaMedeiros -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 20 Jun 2022 13:52:42 GMT ✔ Approvals: 1 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/43506#pullrequestreview-1017419635 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 43506 From https://github.com/nodejs/node * branch refs/pull/43506/merge -> FETCH_HEAD ✔ Fetched commits as bb30e2da7a31..40906b8045ff -------------------------------------------------------------------------------- [main 65dda400d8] tools: fix CJS/ESM toggle on small screens Author: Antoine du Hamel Date: Mon Jun 20 14:36:00 2022 +0200 3 files changed, 26 insertions(+), 1 deletion(-) [main 97a637410d] fixup! tools: fix CJS/ESM toggle on small screens Author: Antoine du Hamel Date: Wed Jun 22 16:33:08 2022 +0200 3 files changed, 22 insertions(+), 14 deletions(-) create mode 100644 tools/doc/buildCSSForFlavoredJS.mjs [main 7f3dd1a10a] fixup! tools: fix CJS/ESM toggle on small screens Author: Antoine du Hamel Date: Thu Jun 23 17:07:40 2022 +0200 1 file changed, 43 insertions(+), 1 deletion(-) [main 1f3a1ab9fb] fixup! tools: fix CJS/ESM toggle on small screens Author: Antoine du Hamel Date: Thu Jun 23 19:40:27 2022 +0200 1 file changed, 1 insertion(+) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/5) Rebasing (3/5) Rebasing (4/5) Rebasing (5/5)https://github.com/nodejs/node/actions/runs/2570321424 |
Landed in 7cbcc4f |
PR-URL: #43506 Co-authored-by: Moshe Atlow <[email protected]> Fixes: #43468 Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: #43506 Co-authored-by: Moshe Atlow <[email protected]> Fixes: #43468 Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: #43506 Co-authored-by: Moshe Atlow <[email protected]> Fixes: #43468 Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: nodejs/node#43506 Co-authored-by: Moshe Atlow <[email protected]> Fixes: nodejs/node#43468 Reviewed-By: LiviaMedeiros <[email protected]>
Alternative to #43495. Opening as draft because
all.html
changes are not yet implemented, I'd like to first get some feedback whether that's something we want to do or not.Fixes: #43468
Co-authored-by: Moshe Atlow [email protected]