Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use unique file names in fs trace test #43504

Merged
merged 1 commit into from
Jun 22, 2022
Merged

test: use unique file names in fs trace test #43504

merged 1 commit into from
Jun 22, 2022

Commits on Jun 20, 2022

  1. test: use unique file names in fs trace test 

    Should fix test flakiness that is presumably caused by the asynchronous
nature of the unlink operation on Windows.

It's been observed that sub-tests randomly fail with "permission denied"
errors when trying to create a new file in a directory with appropriate
permissions.

The DeleteFile() NT API call makes a file inaccessible and marks it for
deletion but doesn't actually delete it until the last open handle has
been closed. Accessing such a file fails with ERROR_ACCESS_DENIED.

Processes can close handles manually or wait for the operating system to
close them asynchronously after process termination. I speculate it's
the latter that's causing the test to turn flaky.

Fixes: nodejs#43502
    @bnoordhuis
    bnoordhuis committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    996d1eb View commit details
    Browse the repository at this point in the history