Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update wpt tests for encoding #43484

Closed
wants to merge 1 commit into from
Closed

Conversation

F3n67u
Copy link
Member

@F3n67u F3n67u commented Jun 19, 2022

The PR:
1. update WPT test for encoding and resources to latest commit: automated by git node wpt
2. add isShadowRealm to global.GLOBAL to avoid wpt test crash: without this property test will fail with global.GLOBAL.isShadowRealm is not a function see https://github.com/web-platform-tests/wpt/blob/master/resources/testharness.js#L544

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 19, 2022
@F3n67u F3n67u marked this pull request as ready for review June 19, 2022 11:11
@F3n67u F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2022
@nodejs-github-bot
Copy link
Collaborator

@F3n67u
Copy link
Member Author

F3n67u commented Jul 24, 2022

Close in favor of #43958

@F3n67u F3n67u closed this Jul 24, 2022
@F3n67u F3n67u deleted the wpt-encoding branch July 24, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants