Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: refactor create buffer #4340

Closed
wants to merge 1 commit into from
Closed

buffer: refactor create buffer #4340

wants to merge 1 commit into from

Conversation

JacksonTian
Copy link
Contributor

Use createBuffer to reduce new Uint8Array()
and setPrototypeOf.

@JacksonTian
buffer: refactor create buffer
4baf407 
Use createBuffer to reduce new Uint8Array()
and setPrototypeOf.
@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label Dec 18, 2015
@Fishrock123
Copy link
Contributor

R=@trevnorris

@bnoordhuis
Copy link
Member

LGTM, seems like an uncontroversial change to me. CI: https://ci.nodejs.org/job/node-test-pull-request/1027/

@JacksonTian
Copy link
Contributor Author

Thanks @bnoordhuis , seems like two unrelated test cases failed.

@targos
Copy link
Member

targos commented Dec 21, 2015

LGTM

1 similar comment
@ChALkeR
Copy link
Member

ChALkeR commented Dec 21, 2015

LGTM

@trevnorris
Copy link
Contributor

Benchmarks look good. LGTM

jasnell pushed a commit that referenced this pull request Dec 24, 2015
@JacksonTian @jasnell
buffer: refactor create buffer
26a8297 
Use createBuffer to reduce new Uint8Array()
and setPrototypeOf.

PR-URL: #4340
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@jasnell
Copy link
Member

jasnell commented Dec 24, 2015

Landed in 26a8297

@jasnell jasnell closed this Dec 24, 2015
@JacksonTian JacksonTian deleted the create_buffer branch December 24, 2015 02:28
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
@JacksonTian @Fishrock123
buffer: refactor create buffer
8781c59 
Use createBuffer to reduce new Uint8Array()
and setPrototypeOf.

PR-URL: nodejs#4340
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
@JacksonTian
buffer: refactor create buffer
b3c9917 
Use createBuffer to reduce new Uint8Array()
and setPrototypeOf.

PR-URL: #4340
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@JacksonTian
buffer: refactor create buffer
44ee33f 
Use createBuffer to reduce new Uint8Array()
and setPrototypeOf.

PR-URL: #4340
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@JacksonTian
buffer: refactor create buffer
5aacbbb 
Use createBuffer to reduce new Uint8Array()
and setPrototypeOf.

PR-URL: nodejs#4340
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@snyk-bot snyk-bot mentioned this pull request Feb 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@JacksonTian @Fishrock123 @bnoordhuis @targos @ChALkeR @trevnorris @jasnell @mscdex @MylesBorins