-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix typo in globals.md #43365
Merged
nodejs-github-bot
merged 1 commit into
nodejs:master
from
daeyeon:master.doc-220610.Fri.04ec
Jun 10, 2022
Merged
doc: fix typo in globals.md #43365
nodejs-github-bot
merged 1 commit into
nodejs:master
from
daeyeon:master.doc-220610.Fri.04ec
Jun 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use apostrophe for possessive. Signed-off-by: Daeyeon Jeong [email protected]
cjihrig
approved these changes
Jun 10, 2022
RaisinTen
approved these changes
Jun 10, 2022
marsonya
approved these changes
Jun 10, 2022
marsonya
added
fast-track
PRs that do not need to wait for 48 hours to land.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Jun 10, 2022
Fast-track has been requested by @marsonya. Please 👍 to approve. |
VoltrexKeyva
approved these changes
Jun 10, 2022
lpinca
approved these changes
Jun 10, 2022
marsonya
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 10, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 10, 2022
Landed in cb7e854 |
danielleadams
pushed a commit
that referenced
this pull request
Jun 11, 2022
Use apostrophe for possessive. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #43365 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
Use apostrophe for possessive. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #43365 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
Use apostrophe for possessive. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #43365 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Use apostrophe for possessive. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #43365 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Use apostrophe for possessive. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #43365 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Use apostrophe for possessive. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: nodejs/node#43365 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use apostrophe for possessive.
Signed-off-by: Daeyeon Jeong [email protected]