Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in globals.md #43365

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Jun 10, 2022

Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]

Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 10, 2022
@marsonya marsonya added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 10, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @marsonya. Please 👍 to approve.

@marsonya marsonya added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2022
@nodejs-github-bot nodejs-github-bot merged commit cb7e854 into nodejs:master Jun 10, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in cb7e854

@daeyeon daeyeon deleted the master.doc-220610.Fri.04ec branch June 10, 2022 10:48
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43365
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43365
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43365
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43365
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43365
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: nodejs/node#43365
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants