-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf_hooks: fix function wrapped by performance.timerify to work correctly #43330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
labels
Jun 6, 2022
cola119
changed the title
pref_hooks: fix function wrapped by timerify to work correctly
perf_hooks: fix function wrapped by timerify to work correctly
Jun 6, 2022
cola119
changed the title
perf_hooks: fix function wrapped by timerify to work correctly
perf_hooks: fix function wrapped by performance.timerify to work correctly
Jun 6, 2022
This comment was marked as resolved.
This comment was marked as resolved.
RaisinTen
added
perf_hooks
Issues and PRs related to the implementation of the Performance Timing API.
and removed
util
Issues and PRs related to the built-in util module.
labels
Jun 6, 2022
aduh95
reviewed
Jun 7, 2022
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
approved these changes
Jun 7, 2022
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jun 7, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 7, 2022
This comment was marked as outdated.
This comment was marked as outdated.
RaisinTen
approved these changes
Jun 8, 2022
JungMinu
approved these changes
Jun 9, 2022
jasnell
approved these changes
Jun 12, 2022
aduh95
added
commit-queue
Add this label to land a pull request using GitHub Actions.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
labels
Jun 12, 2022
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Jun 12, 2022
Commit Queue failed- Loading data for nodejs/node/pull/43330 ✔ Done loading data for nodejs/node/pull/43330 ----------------------------------- PR info ------------------------------------ Title perf_hooks: fix function wrapped by performance.timerify to work correctly (#43330) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch cola119:issue-40623 -> nodejs:master Labels c++, author ready, perf_hooks, needs-ci, commit-queue-squash Commits 2 - perf_hooks: fix function wrapped by timerify to work correctly - fixup! perf_hooks: fix function wrapped by timerify to work correctly Committers 2 - cola119 - GitHub PR-URL: https://github.com/nodejs/node/pull/43330 Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen Reviewed-By: Minwoo Jung Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43330 Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen Reviewed-By: Minwoo Jung Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 06 Jun 2022 14:18:45 GMT ✔ Approvals: 4 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43330#pullrequestreview-998895212 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43330#pullrequestreview-999103530 ✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/43330#pullrequestreview-1001101980 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/43330#pullrequestreview-1003513143 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-06-08T04:36:30Z: https://ci.nodejs.org/job/node-test-pull-request/44403/ - Querying data for job/node-test-pull-request/44403/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2483034882 |
Landed in 8d5a3e3 |
italojs
pushed a commit
to italojs/node
that referenced
this pull request
Jun 12, 2022
PR-URL: nodejs#43330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
PR-URL: #43330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
15 tasks
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
PR-URL: #43330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
needs-ci
PRs that need a full CI run.
perf_hooks
Issues and PRs related to the implementation of the Performance Timing API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #40623
(#40625 also fixes this issue but it has been stale and seems not expected to be updated.)
This issue introduced by the refactoring on #37136. The previous implementation was checking whether a function or class is called using the new operator to proxy a function call.
node/src/node_perf.cc
Lines 380 to 393 in 74227bb
This PR fixed to align with the previous behavior that a function works the same as if it was called directly.