Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x] deps: cherry-pick 4ab70f6 from V8 upstream #43328

Closed
wants to merge 1 commit into from
Closed

[v16.x] deps: cherry-pick 4ab70f6 from V8 upstream #43328

wants to merge 1 commit into from

Conversation

XadillaX
Copy link
Contributor

@XadillaX XadillaX commented Jun 6, 2022 

[Compiler] Remove untrusted code mitigations.

These are no longer enabled, so remove the code mitigation logic from
the codebase.

BUG=chromium:1003890

Change-Id: I536bb1732e8463281c21da446bbba8f47ede8ebe
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045704
Commit-Queue: Ross McIlroy <[email protected]>
Reviewed-by: Jakob Gruber <[email protected]>
Reviewed-by: Clemens Backes <[email protected]>
Cr-Commit-Position: refs/heads/master@{#76256}

Refs: v8/v8@4ab70f6
Fixes: #43296

@XadillaX
deps: cherry-pick 4ab70f6 from V8 upstream
ece86ce 
    [Compiler] Remove untrusted code mitigations.

    These are no longer enabled, so remove the code mitigation logic from
    the codebase.

    BUG=chromium:1003890

    Change-Id: I536bb1732e8463281c21da446bbba8f47ede8ebe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045704
    Commit-Queue: Ross McIlroy <[email protected]>
    Reviewed-by: Jakob Gruber <[email protected]>
    Reviewed-by: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#76256}

Refs: v8/v8@4ab70f6
Fixes: nodejs#43296
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v16.x v8 engine Issues and PRs related to the V8 dependency. labels Jun 6, 2022
bnoordhuis
bnoordhuis approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM. It's been broken for years (at least since 2020), maybe almost as long as it's been around.

@richardlau richardlau changed the title deps: cherry-pick 4ab70f6 from V8 upstream [v16.x] deps: cherry-pick 4ab70f6 from V8 upstream Jun 6, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44808/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44820/

@danielleadams
Copy link
Contributor

Landed in f2dc43a

danielleadams pushed a commit that referenced this pull request Jun 26, 2022
@XadillaX @danielleadams
deps: cherry-pick 4ab70f6 from V8 upstream
f2dc43a 
    [Compiler] Remove untrusted code mitigations.

    These are no longer enabled, so remove the code mitigation logic from
    the codebase.

    BUG=chromium:1003890

    Change-Id: I536bb1732e8463281c21da446bbba8f47ede8ebe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045704
    Commit-Queue: Ross McIlroy <[email protected]>
    Reviewed-by: Jakob Gruber <[email protected]>
    Reviewed-by: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#76256}

Refs: v8/v8@4ab70f6
Fixes: #43296

PR-URL: #43328
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@github-actions github-actions bot mentioned this pull request Jun 27, 2022
Open
33 tasks
danielleadams pushed a commit that referenced this pull request Jul 7, 2022
@XadillaX @danielleadams
deps: cherry-pick 4ab70f6 from V8 upstream
01e7d1f 
    [Compiler] Remove untrusted code mitigations.

    These are no longer enabled, so remove the code mitigation logic from
    the codebase.

    BUG=chromium:1003890

    Change-Id: I536bb1732e8463281c21da446bbba8f47ede8ebe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045704
    Commit-Queue: Ross McIlroy <[email protected]>
    Reviewed-by: Jakob Gruber <[email protected]>
    Reviewed-by: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#76256}

Refs: v8/v8@4ab70f6
Fixes: #43296

PR-URL: #43328
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Jul 18, 2022
Closed
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@XadillaX @guangwong
deps: cherry-pick 4ab70f6 from V8 upstream
3f88e57 
    [Compiler] Remove untrusted code mitigations.

    These are no longer enabled, so remove the code mitigation logic from
    the codebase.

    BUG=chromium:1003890

    Change-Id: I536bb1732e8463281c21da446bbba8f47ede8ebe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045704
    Commit-Queue: Ross McIlroy <[email protected]>
    Reviewed-by: Jakob Gruber <[email protected]>
    Reviewed-by: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#76256}

Refs: v8/v8@4ab70f6
Fixes: nodejs/node#43296

PR-URL: nodejs/node#43328
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
davidjb added a commit to davidjb/isolated-vm that referenced this pull request Mar 7, 2024
@davidjb
Remove mention of --untrusted-code-mitigations in README.md
663673e 
This functionality was removed in Node 16.17.0 and 17.0.0.  Comments on the relevant issues suggest this mitigations may never have worked:

nodejs/node#43296
nodejs/node#43328
@davidjb davidjb mentioned this pull request Mar 7, 2024
Merged
laverdet pushed a commit to laverdet/isolated-vm that referenced this pull request Mar 7, 2024
@davidjb
Remove mention of --untrusted-code-mitigations in README.md (#458)
e65b6b7 
This functionality was removed in Node 16.17.0 and 17.0.0.  Comments on the relevant issues suggest this mitigations may never have worked:

nodejs/node#43296
nodejs/node#43328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@tniessen tniessen tniessen approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@XadillaX @nodejs-github-bot @danielleadams @bnoordhuis @tniessen @gengjiawen @VoltrexKeyva