Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix Visual Studio 2019 download link #43236

Merged
merged 1 commit into from
Jun 21, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -566,9 +566,9 @@ to run it again before invoking `make -j4`.

* [Python 3.10](https://www.microsoft.com/en-us/p/python-310/9pjpw5ldxlz5)
* The "Desktop development with C++" workload from
[Visual Studio 2019](https://visualstudio.microsoft.com/downloads/) or
[Visual Studio 2019](https://visualstudio.microsoft.com/vs/older-downloads/#visual-studio-2019-and-other-products) or
the "C++ build tools" workload from the
[Build Tools](https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019),
[Build Tools](https://aka.ms/vs/16/release/vs_buildtools.exe),
Copy link
Member Author

@F3n67u F3n67u May 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019 link is also broken, I cannot find a visual studio 2019 c++ build tools link from https://visualstudio.microsoft.com/downloads.

Using https://aka.ms/vs/16/release/vs_buildtools.exe link to download visual studio 2019 build tools is documented at
https://docs.microsoft.com/en-us/visualstudio/install/build-tools-container?view=vs-2019#create-and-build-the-dockerfile.

image

I have verified this link does works on my windows server: uninstall already installed visual studio 2019, install build tool via the build tools link, and verify .\vcbuild does compile.

with the default optional components
* Basic Unix tools required for some tests,
[Git for Windows](https://git-scm.com/download/win) includes Git Bash
Expand Down