Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: modify then to async/await #43224

Closed
wants to merge 5 commits into from
Closed

test: modify then to async/await #43224

wants to merge 5 commits into from

Conversation

meekdenzo
Copy link
Contributor

This modification converts a long chain of thens to an async function with awaits.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 28, 2022
@Trott
Copy link
Member

Trott commented May 28, 2022

The commit should start with the subsystem test, so maybe test: modify then to async/await?

@meekdenzo
Copy link
Contributor Author

The commit should start with the subsystem test, so maybe test: modify then to async/await?

Noted. Thanks for pointing that out

@meekdenzo meekdenzo changed the title modify: then to async/await test: modify then to async/await May 28, 2022
@LiviaMedeiros LiviaMedeiros added test Issues and PRs related to the tests. and removed c++ Issues and PRs that require attention from people who are familiar with C++. labels May 28, 2022
@Trott
Copy link
Member

Trott commented Jun 2, 2022

Closing in favor of #43292

@Trott Trott closed this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meekdenzo @Trott @nodejs-github-bot @LiviaMedeiros