src: refactor GetCipherValue and related functions #43171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
Modernize and simplify GetCipherValue and its call sites.
tniessen
force-pushed
the
src-refactor-getciphervalue
branch
from
56a9bf4
to
685c692
Compare
github-actions
bot
removed
the
request-ci
bnoordhuis
approved these changes
May 22, 2022
tniessen
added
the
author ready
JungMinu
approved these changes
May 24, 2022
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 304e06a |
bengl
pushed a commit
that referenced
this pull request
May 30, 2022
Modernize and simplify GetCipherValue and its call sites. PR-URL: #43171 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Merged
|
@tniessen this refactor broke the node build when pulling into v16.x. Do you mind creating a backport PR? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize and simplify
GetCipherValueand its call sites to remove ~30 lines of code.