Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add mailmap entry for ShogunPanda #43094

Merged
merged 1 commit into from
May 15, 2022

Conversation

ShogunPanda
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 14, 2022
@ShogunPanda ShogunPanda mentioned this pull request May 14, 2022
@ShogunPanda ShogunPanda changed the title Mailmap meta: add mailmap entry for ShogunPanda May 14, 2022
@aduh95 aduh95 requested a review from Trott May 14, 2022 09:10
.mailmap Outdated
Comment on lines 386 to 388
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines aren't needed unless you plan to commit from those email addresses in the future.

Suggested change

@ShogunPanda ShogunPanda added the fast-track PRs that do not need to wait for 48 hours to land. label May 14, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @ShogunPanda. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43094
✔  Done loading data for nodejs/node/pull/43094
----------------------------------- PR info ------------------------------------
Title      meta: add mailmap entry for ShogunPanda (#43094)
Author     Paolo Insogna  (@ShogunPanda)
Branch     ShogunPanda:mailmap -> nodejs:master
Labels     meta, fast-track
Commits    2
 - meta: add mailmap entry for ShogunPanda
 - meta: respect alphabetical order
Committers 1
 - Paolo Insogna 
PR-URL: https://github.com/nodejs/node/pull/43094
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43094
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 14 May 2022 05:51:43 GMT
   ✔  Approvals: 2
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43094#pullrequestreview-973087994
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43094#pullrequestreview-973092919
   ℹ  This PR is being fast-tracked
   ✖  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2325051169

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 14, 2022
@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 14, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43094
✔  Done loading data for nodejs/node/pull/43094
----------------------------------- PR info ------------------------------------
Title      meta: add mailmap entry for ShogunPanda (#43094)
Author     Paolo Insogna  (@ShogunPanda)
Branch     ShogunPanda:mailmap -> nodejs:master
Labels     meta, fast-track, commit-queue-squash
Commits    2
 - meta: add mailmap entry for ShogunPanda
 - meta: respect alphabetical order
Committers 1
 - Paolo Insogna 
PR-URL: https://github.com/nodejs/node/pull/43094
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43094
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 14 May 2022 05:51:43 GMT
   ✔  Approvals: 2
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43094#pullrequestreview-973087994
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43094#pullrequestreview-973092919
   ℹ  This PR is being fast-tracked
   ✖  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2325080361

@Trott
Copy link
Member

Trott commented May 15, 2022

Not sure why the Windows stuff is failing in GitHub CI, but I rebased and force-pushed in case the fix is on the master branch.

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 15, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2022
@nodejs-github-bot nodejs-github-bot merged commit 8a5657b into nodejs:master May 15, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 8a5657b

@ShogunPanda ShogunPanda deleted the mailmap branch May 16, 2022 04:52
BethGriggs pushed a commit that referenced this pull request May 16, 2022
PR-URL: #43094
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #43094
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #43094
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43094
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43094
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43094
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants