Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-crypto-fips.js fails with shared OpenSSL 3 #42947

Closed
wants to merge 1 commit into from
Closed

test-crypto-fips.js fails with shared OpenSSL 3 #42947

wants to merge 1 commit into from

Conversation

batrla
Copy link
Contributor

@batrla batrla commented May 2, 2022

closes #42827

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 2, 2022
@mhdawson
Copy link
Member

mhdawson commented May 2, 2022

@danbev can you take a look at this one?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43848/

@tniessen tniessen requested a review from bnoordhuis May 3, 2022 13:11
mhdawson
mhdawson approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented May 4, 2022

Landed in 2454aa0

@mhdawson mhdawson closed this May 4, 2022
mhdawson pushed a commit that referenced this pull request May 4, 2022
@mhdawson
test: fix test-crypto-fips.js under shared OpenSSL
2454aa0 
Fixes: #42827

PR-URL: #42947
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
@RafaelGSS
test: fix test-crypto-fips.js under shared OpenSSL
d746207 
Fixes: #42827

PR-URL: #42947
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 10, 2022
Merged
@juanarbol
Copy link
Member

OpenSSL 3 is not part of v16.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@tniessen tniessen tniessen approved these changes

@danbev danbev danbev approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test/parallel/test-crypto-fips.js fails if node is built with --shared-openssl and --openssl-is-fips
7 participants
@batrla @mhdawson @nodejs-github-bot @juanarbol @bnoordhuis @danbev @tniessen