Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16.15.0 release proposal #42847

Merged
merged 254 commits into from
Apr 26, 2022
Merged

v16.15.0 release proposal #42847

merged 254 commits into from
Apr 26, 2022

Conversation

danielleadams
Copy link
Member

@danielleadams danielleadams commented Apr 24, 2022

2022-04-26, Version 16.15.0 'Gallium' (LTS), @danielleadams

Notable changes

Add fetch API

Adds experimental support to the fetch API. This adds the --experimental-fetch
flag that installs the fetch, Request, Response, Headers, and FormData
globals.

  • (SEMVER-MINOR) add fetch (Michaël Zasso) #41749
  • (SEMVER-MINOR) add FormData global when fetch is enabled (Michaël Zasso) #41956

Other notable changes

  • build:
    • remove broken x32 arch support (Ben Noordhuis) #41905
  • crypto:
    • (SEMVER-MINOR) add KeyObject.prototype.equals method (Filip Skokan) #42093
  • doc:
  • esm:
    • (SEMVER-MINOR) support https remotely and http locally under flag (Bradley Farias) #36328
  • module:
    • (SEMVER-MINOR) unflag esm json modules (Geoffrey Booth) #41736
  • node-api:
    • (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329
  • process:
    • deprecate multipleResolves (Benjamin Gruenbaum) #41872
  • stream:
    • (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573
    • (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553
    • (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445

Commits

targos and others added 30 commits April 20, 2022 20:11
Fixes: #19393

PR-URL: #41749
Backport-PR-URL: #42727
Refs: nodejs/undici#1183
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
PR-URL: #41955
Backport-PR-URL: #42727
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
This also adds a script to automate the update and includes the sources
included in the npm tarball.

PR-URL: #42246
Backport-PR-URL: #42727
Fixes: #42199
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
PR-URL: #42414
Backport-PR-URL: #42727
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
PR-URL: #42583
Backport-PR-URL: #42727
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
PR-URL: #41956
Backport-PR-URL: #42727
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Add a `forEach` method to readable streams to enable concurrent
iteration and align with the iterator-helpers proposal.

Co-Authored-By: Robert Nagy <[email protected]>
PR-URL: #41445
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
PR-URL: #41487
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
The 'subject' option should not only accept the values 'always' and
'never' because neither is compatible with RFC 2818, i.e., HTTPS. This
change adds a third value 'default', which implies the behavior that
HTTPS mandates.

The new 'default' case matches the default behavior of OpenSSL for both
DNS names and email addresses.

Future Node.js versions should change the default option value from
'always' to 'default'.

Refs: #36804

PR-URL: #41569
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Add the toArray method from the TC39 iterator helper proposal to
Readable streams. This also enables a common-use case of converting a
stream to an array.

Co-Authored-By: Robert Nagy <[email protected]>
PR-URL: #41553
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Refs: #41569

PR-URL: #41613
Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
This continues on the iterator-helpers work by adding `.some` and
`.every` to readable streams.

Co-Authored-By: Robert Nagy <[email protected]>
PR-URL: #41573
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #41596
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #41596
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #41596
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Support the `flatMap` method from the iterator helper TC39 proposal on
readable streams.

Co-Authored-By: Robert Nagy <[email protected]>
PR-URL: #41612
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
This adds the `drop` and `take` methods to readable streams allowing
users easily drop and take items from the stream.

This continues the iterator-helper proposal alignment task.

Co-Authored-By: Robert Nagy <[email protected]>
PR-URL: #41630
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Fixes: #41294

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #41329
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Add the asIndexedPairs method for readable streams.

PR-URL: #41681
Refs: https://github.com/tc39/proposal-iterator-helpers#asindexedpairs
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
The OOM test uses a value that caused an OOM crash from V8 on certain
machines when V8 did not notify the host of OOM soon enough.

PR-URL: #41681
Refs: https://github.com/tc39/proposal-iterator-helpers#asindexedpairs
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
 is no longer a generator function,
instead it returns a called generator so that validation can be
synchronous and not wait for the first iteration

Fixes: #41648

PR-URL: #41652
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
PR-URL: #41669
Reviewed-By: Matteo Collina <[email protected]>
Signed-off-by: James M Snell <[email protected]>

PR-URL: #41272
Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #41791
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Fixes: #41633
Fixes: #40958

- move test-crypto-engine so that dummy engine
  is only built if tests are run

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41830
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Fixes: #41857

PR-URL: #41864
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Deprecate the process multipleResolves event to detect when a promise is
resolved more than once because it never really worked.

Fixes: #41554

PR-URL: #41872
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Mestery <[email protected]>
PR-URL: #41892
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
The `closed` promise may reject. Document the states where it rejects
based on the spec.

Fixes: #41858

PR-URL: #41860
Co-Authored-By: Mattias Buelens <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
replacable -> replaceable

PR-URL: #41891
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadams
Copy link
Member Author

cc @nodejs/releasers @nodejs/collaborators

@mcollina
Copy link
Member

@danielleadams you should update the name of @ShogunPanda - he is Paolo Insogna.

danielleadams added a commit that referenced this pull request Apr 25, 2022
Notable changes:

Add fetch API

Adds experimental support to the fetch API. This adds a `--experimental-fetch`
flag that installs the `fetch`, `Request`, `Reponse` and `Headers` globals.

* (SEMVER-MINOR) add fetch (Michaël Zasso) #41749

Other notable changes

* build:
  * remove broken x32 arch support (Ben Noordhuis) #41905
* crypto:
  * (SEMVER-MINOR) add KeyObject.prototype.equals method (Filip Skokan) #42093
* doc:
  * add @ShogunPanda to collaborators (Paolo Insogna) #42362
  * add JakobJingleheimer to collaborators list (Jacob Smith) #42185
  * add joesepi to collaborators (Joe Sepi) #41914
  * add marsonya to collaborators (Akhil Marsonya) #41991
  * deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia
    Medeiros) #42149
  * deprecate notice for process methods (Yash Ladha) #41587
* esm:
  * (SEMVER-MINOR) support https remotely and http locally under flag
    (Bradley Farias) #36328
* module:
  * (SEMVER-MINOR) unflag esm json modules (Geoffrey Booth) #41736
* node-api:
  * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329
* process:
  * deprecate multipleResolves (Benjamin Gruenbaum) #41872
* stream:
  * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573
  * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553
  * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445

PR-URL: #42847
@nodejs-github-bot

This comment was marked as outdated.

#### Add fetch API

Adds experimental support to the fetch API. This adds a `--experimental-fetch`
flag that installs the `fetch`, `Request`, `Reponse` and `Headers` globals.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
flag that installs the `fetch`, `Request`, `Reponse` and `Headers` globals.
flag that installs the `fetch`, `Request`, `Reponse`, `Headers`, and `FormData` globals.

danielleadams added a commit that referenced this pull request Apr 26, 2022
Notable changes:

Add fetch API

Adds experimental support to the fetch API. This adds a `--experimental-fetch`
flag that installs the `fetch`, `Request`, `Reponse``Headers`, and `FormData`
globals.

* (SEMVER-MINOR) add fetch (Michaël Zasso) #41749
* (SEMVER-MINOR) add FormData global when fetch is enabled (Michaël Zasso) #41956

Other notable changes

* build:
  * remove broken x32 arch support (Ben Noordhuis) #41905
* crypto:
  * (SEMVER-MINOR) add KeyObject.prototype.equals method (Filip Skokan) #42093
* doc:
  * add @ShogunPanda to collaborators (Paolo Insogna) #42362
  * add JakobJingleheimer to collaborators list (Jacob Smith) #42185
  * add joesepi to collaborators (Joe Sepi) #41914
  * add marsonya to collaborators (Akhil Marsonya) #41991
  * deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia
    Medeiros) #42149
  * deprecate notice for process methods (Yash Ladha) #41587
* esm:
  * (SEMVER-MINOR) support https remotely and http locally under flag
    (Bradley Farias) #36328
* module:
  * (SEMVER-MINOR) unflag esm json modules (Geoffrey Booth) #41736
* node-api:
  * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329
* process:
  * deprecate multipleResolves (Benjamin Gruenbaum) #41872
* stream:
  * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573
  * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553
  * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445

PR-URL: #42847
@nodejs-github-bot

This comment was marked as outdated.

Copy link
Member

@BethGriggs BethGriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate all your work on this - these minor releases take a lot!

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the commit message

`Reponse``Headers` -> `Response`, `Headers`

#### Add fetch API

Adds experimental support to the fetch API. This adds a `--experimental-fetch`
flag that installs the `fetch`, `Request`, `Reponse`, `Headers`, and `FormData`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
flag that installs the `fetch`, `Request`, `Reponse`, `Headers`, and `FormData`
flag that installs the `fetch`, `Request`, `Response`, `Headers`, and `FormData`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed it - thanks for catching.

Notable changes:

Add fetch API

Adds experimental support to the fetch API. This adds the `--experimental-fetch`
flag that installs the `fetch`, `Request`, `Response`, `Headers`, and `FormData`
globals.

* (SEMVER-MINOR) add fetch (Michaël Zasso) #41749
* (SEMVER-MINOR) add FormData global when fetch is enabled (Michaël Zasso) #41956

Other notable changes

* build:
  * remove broken x32 arch support (Ben Noordhuis) #41905
* crypto:
  * (SEMVER-MINOR) add KeyObject.prototype.equals method (Filip Skokan) #42093
* doc:
  * add @ShogunPanda to collaborators (Paolo Insogna) #42362
  * add JakobJingleheimer to collaborators list (Jacob Smith) #42185
  * add joesepi to collaborators (Joe Sepi) #41914
  * add marsonya to collaborators (Akhil Marsonya) #41991
  * deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia
    Medeiros) #42149
  * deprecate notice for process methods (Yash Ladha) #41587
* esm:
  * (SEMVER-MINOR) support https remotely and http locally under flag
    (Bradley Farias) #36328
* module:
  * (SEMVER-MINOR) unflag esm json modules (Geoffrey Booth) #41736
* node-api:
  * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329
* process:
  * deprecate multipleResolves (Benjamin Gruenbaum) #41872
* stream:
  * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573
  * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553
  * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445

PR-URL: #42847
@nodejs-github-bot
Copy link
Collaborator

@danielleadams danielleadams merged commit e243282 into v16.x Apr 26, 2022
danielleadams added a commit that referenced this pull request Apr 26, 2022
danielleadams added a commit that referenced this pull request Apr 27, 2022
Notable changes:

Add fetch API

Adds experimental support to the fetch API. This adds the `--experimental-fetch`
flag that installs the `fetch`, `Request`, `Response`, `Headers`, and `FormData`
globals.

* (SEMVER-MINOR) add fetch (Michaël Zasso) #41749
* (SEMVER-MINOR) add FormData global when fetch is enabled (Michaël Zasso) #41956

Other notable changes

* build:
  * remove broken x32 arch support (Ben Noordhuis) #41905
* crypto:
  * (SEMVER-MINOR) add KeyObject.prototype.equals method (Filip Skokan) #42093
* doc:
  * add @ShogunPanda to collaborators (Paolo Insogna) #42362
  * add JakobJingleheimer to collaborators list (Jacob Smith) #42185
  * add joesepi to collaborators (Joe Sepi) #41914
  * add marsonya to collaborators (Akhil Marsonya) #41991
  * deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia
    Medeiros) #42149
  * deprecate notice for process methods (Yash Ladha) #41587
* esm:
  * (SEMVER-MINOR) support https remotely and http locally under flag
    (Bradley Farias) #36328
* module:
  * (SEMVER-MINOR) unflag esm json modules (Geoffrey Booth) #41736
* node-api:
  * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329
* process:
  * deprecate multipleResolves (Benjamin Gruenbaum) #41872
* stream:
  * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573
  * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553
  * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445

PR-URL: #42847
danielleadams added a commit to nodejs/nodejs.org that referenced this pull request Apr 27, 2022
danielleadams added a commit to nodejs/nodejs.org that referenced this pull request Apr 27, 2022
@danielleadams danielleadams deleted the v16.15.0-proposal branch April 27, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.