test: improve lib/internal/webstreams/readablestream.js coverage
#42823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
aduh95
requested changes
Apr 22, 2022
| @@ -209,9 +212,11 @@ class Source { | |||
| reader.releaseLock(); | |||
| assert.rejects(reader.read(new Uint8Array(10)), { | |||
| code: 'ERR_INVALID_STATE', | |||
| message: 'Invalid state: The reader is not attached to a stream', | |||
aduh95
reviewed
Apr 22, 2022
| readableStreamReaderGenericRelease(stream[kState].reader); | ||
| assert.rejects(iterable.next(), { | ||
| code: 'ERR_INVALID_STATE', | ||
| }); |
There was a problem hiding this comment.
Suggested change
| }); | |
| }).then(common.mustCall()); |
| readableStreamReaderGenericRelease(stream[kState].reader); | ||
| assert.rejects(iterable.return(), { | ||
| code: 'ERR_INVALID_STATE', | ||
| }); |
There was a problem hiding this comment.
Suggested change
| }); | |
| }).then(common.mustCall()); |
aduh95
approved these changes
Apr 22, 2022
jasnell
approved these changes
Apr 22, 2022
mhdawson
added
request-ci
github-actions
bot
removed
the
request-ci
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 277353c |
RafaelGSS
pushed a commit
that referenced
this pull request
May 10, 2022
PR-URL: #42823 Refs: https://coverage.nodejs.org/coverage-3a6b975981092213/lib/internal/webstreams/readablestream.js.html#L421 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42823 Refs: https://coverage.nodejs.org/coverage-3a6b975981092213/lib/internal/webstreams/readablestream.js.html#L421 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42823 Refs: https://coverage.nodejs.org/coverage-3a6b975981092213/lib/internal/webstreams/readablestream.js.html#L421 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #42823 Refs: https://coverage.nodejs.org/coverage-3a6b975981092213/lib/internal/webstreams/readablestream.js.html#L421 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42823 Refs: https://coverage.nodejs.org/coverage-3a6b975981092213/lib/internal/webstreams/readablestream.js.html#L421 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42823 Refs: https://coverage.nodejs.org/coverage-3a6b975981092213/lib/internal/webstreams/readablestream.js.html#L421 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improve
lib/internal/webstreams/readablestream.jscoverageRefs: