Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify guide on testing internal errors #42813

Merged
merged 2 commits into from
Apr 27, 2022
Merged

doc: clarify guide on testing internal errors #42813

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19cf7ef
doc: clarify guide on testing internal errors
LiviaMedeiros Apr 21, 2022
24d9407
squash: add articles
LiviaMedeiros Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions doc/contributing/writing-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,18 @@ assert.throws(
);
```

In the case of internal errors, prefer checking only the `code` property:

```js
assert.throws(
() => {
throw new ERR_FS_FILE_TOO_LARGE(`${sizeKiB} Kb`);
},
{ code: 'ERR_FS_FILE_TOO_LARGE' }
// Do not include message: /^File size ([0-9]+ Kb) is greater than 2 GiB$/
);
```

### Console output

Output written by tests to stdout or stderr, such as with `console.log()` or
Expand Down