doc: elevate node-clinic diagnostic tier #42802
Conversation
|
Review requested:
|
cc @nodejs/diagnostics @nodejs/releasers |
Me neither. I think we test it in CITGM but that isn't run nightly. |
|
I would consider |
FWIW clinic is currently skipped in citgm for AIX and Windows: https://github.com/nodejs/citgm/blob/fcfc781e72e6ed79ccd8a4e189960111c55f722a/lib/lookup.json#L97-L102 |
I think that if we agree on that, then the entry should be updated to show that test are being run. |
Can you elaborate, please? Should I change https://github.com/nodejs/citgm/blob/fcfc781e72e6ed79ccd8a4e189960111c55f722a/lib/lookup.json#L97-L102 to not skip those tests? btw AIX is not supported AFAIK |
PR-URL: #42802 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
|
Landed in d8460de |
PR-URL: #42802 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
PR-URL: #42802 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
PR-URL: #42802 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
PR-URL: #42802 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
PR-URL: #42802 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
PR-URL: nodejs/node#42802 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: nodejs#42802
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: #42802 PR-URL: #42805 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: #42802 PR-URL: #42805 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: #42802 PR-URL: #42805 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: #42802 PR-URL: #42805 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Fixes: nodejs/diagnostics#537.
As discussed in the last Diagnostics WG(nodejs/diagnostics#552). I'm not sure how the
node-clinictests could be integrated into the nightly CI.