Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 10.2 #42740

Closed
wants to merge 13 commits into from
Closed

deps: update V8 to 10.2 #42740

wants to merge 13 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 14, 2022

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 14, 2022
@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. needs-ci PRs that need a full CI run. and removed doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. needs-ci PRs that need a full CI run. labels Apr 14, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 14, 2022

@targos
Copy link
Member Author

targos commented Apr 14, 2022

/cc @nodejs/build about 43fbd04

I guess the easiest will be to wait for master to be at 19.0.0-pre so x86 can just be skipped on v18.x (until we are ready to backport this).

@targos
Copy link
Member Author

targos commented Apr 14, 2022

Btw, since I was able to cherry-pick a lot of ABI-breaking changes into the 10.1 update, there's only one remaining change to adapt for this to be semver-minor (v8/v8@1ff685d8b1). I'll try to work on it next week.

@richardlau
Copy link
Member

richardlau commented Apr 14, 2022

/cc @nodejs/build about 43fbd04

I guess the easiest will be to wait for master to be at 19.0.0-pre so x86 can just be skipped on v18.x (until we are ready to backport this).

I think I could adjust nodejs/build@abf9ebd to only apply to Node.js 18 (so when master becomes 19 it will automatically start testing on Windows x86 again).

Update: opened nodejs/build#2927.

@richardlau
Copy link
Member

Do we need aac8b85 as well for the V8 CI? (I guess we'll find out 🙂.)

@targos
Copy link
Member Author

targos commented Apr 14, 2022

Do we need aac8b85 as well for the V8 CI? (I guess we'll find out 🙂.)

I actually squashed it with 76b0ae4. Would you like to be added as a co-author?

@richardlau
Copy link
Member

Do we need aac8b85 as well for the V8 CI? (I guess we'll find out 🙂.)

I actually squashed it with 76b0ae4. Would you like to be added as a co-author?

If it's not too much trouble 🙇‍♂️.

richardlau added a commit to nodejs/build that referenced this pull request Apr 14, 2022
Run 32-bit Windows CI for Node.js 19 but skip (for now) on Node.js 18.

Introduce a new `gteLt` closure for exclusions between two versions.

Refs: nodejs/node#42690
Refs: nodejs/node#42740 (comment)
Refs: #2921
@miladfarca
Copy link
Contributor

I can't reproduce it after multiple runs. Checked out this PR as well as v8 10.2-lkgr directly. Could you re-run the test?

xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
PR-URL: nodejs#42740
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
Create an unused deopt kind to replace `DeoptimizeKind::kSoft`, which
was removed. This ensures that the layout of IsolateData doesn't change.

Refs: v8/v8@1ff685d

PR-URL: nodejs#42740
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
PR-URL: nodejs#42740
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
V8's test runner now requires Python 3. Use the Python binary we
detected that is used elsewhere in the Makefile.

PR-URL: nodejs#42740
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
This reverts commit 35d72bf.

PR-URL: nodejs#42740
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos targos removed the backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. label May 12, 2022
@BethGriggs BethGriggs added backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. and removed backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. labels May 16, 2022
targos added a commit that referenced this pull request May 23, 2022
PR-URL: #42740
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos added a commit that referenced this pull request May 23, 2022
PR-URL: #42740
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos added a commit that referenced this pull request May 23, 2022
Create an unused deopt kind to replace `DeoptimizeKind::kSoft`, which
was removed. This ensures that the layout of IsolateData doesn't change.

Refs: v8/v8@1ff685d

PR-URL: #42740
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos added a commit that referenced this pull request May 23, 2022
PR-URL: #42740
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this pull request May 23, 2022
V8's test runner now requires Python 3. Use the Python binary we
detected that is used elsewhere in the Makefile.

PR-URL: #42740
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos added a commit that referenced this pull request May 23, 2022
This reverts commit 35d72bf.

PR-URL: #42740
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@juanarbol
Copy link
Member

I've tried to land/backport this in v16.x with no success :(

@sepehrst
Copy link

I've tried to land/backport this in v16.x with no success :(

Putting aside the reason behind the failure to backport, Wouldn't this be a semver-major? I think v16 is forever locked to V8 9.4 for the same reason that v18 will be locked to 10.2(Thanks to the forward compatibility patches applied to 10.1 otherwise it would have remained at 10.1) even though it is not reached the LTS phase yet, and v16 is already in LTS.

@targos
Copy link
Member Author

targos commented May 30, 2022

This should not land on v16.x, sorry I forgot the label.
@juanarbol this has not been in a current release yet, so it would have been too early to backport to LTS.

@juanarbol
Copy link
Member

This should not land on v16.x, sorry I forgot the label. @juanarbol this has not been in a current release yet, so it would have been too early to backport to LTS.

It's ok! 💚

bengl added a commit that referenced this pull request May 31, 2022
Notable changes:

* deps: update undici to 5.3.0 (Node.js GitHub Bot) #43197
* (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* deps: upgrade npm to 8.11.0 (npm team) #43210
* deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067
* (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740
* (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112

PR-URL: TBD
@bengl bengl mentioned this pull request May 31, 2022
bengl added a commit that referenced this pull request May 31, 2022
Notable changes:

* deps: update undici to 5.3.0 (Node.js GitHub Bot) #43197
* (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* deps: upgrade npm to 8.11.0 (npm team) #43210
* deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067
* (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740
* (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112

PR-URL: #43266
bengl added a commit that referenced this pull request Jun 1, 2022
Notable changes:

* deps: update undici to 5.3.0 (Node.js GitHub Bot) #43197
* (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* deps: upgrade npm to 8.11.0 (npm team) #43210
* deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067
* (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740
* (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112
* (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740)
  * This means 32-bit Windows binaries are back with this release.

PR-URL: #43266
bengl added a commit that referenced this pull request Jun 1, 2022
Notable changes:

* deps: update undici to 5.3.0 (Node.js GitHub Bot) #43197
* (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* deps: upgrade npm to 8.11.0 (npm team) #43210
* deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067
* (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740
* (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112
* (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740)
  * This means 32-bit Windows binaries are back with this release.

PR-URL: #43266
bengl added a commit that referenced this pull request Jun 1, 2022
Notable changes:

* deps: update undici to 5.4.0  (Node.js GitHub Bot) #43262
* (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* deps: upgrade npm to 8.11.0 (npm team) #43210
* deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067
* (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740
* (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112
* (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740)
  * This means 32-bit Windows binaries are back with this release.

PR-URL: #43266
bengl added a commit that referenced this pull request Jun 2, 2022
Notable changes:

* deps: update undici to 5.4.0  (Node.js GitHub Bot) #43262
* (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* deps: upgrade npm to 8.11.0 (npm team) #43210
* deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067
* (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740
* (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112
* (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740)
  * This means 32-bit Windows binaries are back with this release.

PR-URL: #43266
italojs pushed a commit to italojs/node that referenced this pull request Jun 6, 2022
Notable changes:

* deps: update undici to 5.4.0  (Node.js GitHub Bot) nodejs#43262
* (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) nodejs#42675
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) nodejs#41397
* deps: upgrade npm to 8.11.0 (npm team) nodejs#43210
* deps: patch V8 to 10.2.154.4 (Michaël Zasso) nodejs#43067
* (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) nodejs#42740
* (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) nodejs#42601
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) nodejs#41397
* (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) nodejs#43112
* (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [nodejs#42740](nodejs#42740)
  * This means 32-bit Windows binaries are back with this release.

PR-URL: nodejs#43266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants