Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix added: info for outgoingMessage.writable* #42737

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Apr 14, 2022

  • outgoingMessage.writableCorked was added to Node.js v13.2.0 via
    62e15a7 and backported to Node.js v12.16.0 via db8144b.
  • outgoingMessage.writableEnded was added to Node.js v12.9.0 via
    f9b61d2.
  • outgoingMessage.writableFinished was added to Node.js v12.7.0 via
    06d0abe.
  • outgoingMessage.writableHighWaterMark,
    outgoingMessage.writableLength, and
    outgoingMessage.writableObjectMode were added to Node.js v12.9.0 via
    16e0011.

- `outgoingMessage.writableCorked` was added to Node.js v13.2.0 via
  62e15a7 and backported to Node.js v12.16.0 via db8144b.
- `outgoingMessage.writableEnded` was added to Node.js v12.9.0 via
  f9b61d2.
- `outgoingMessage.writableFinished` was added to Node.js v12.7.0 via
  06d0abe.
- `outgoingMessage.writableHighWaterMark`,
  `outgoingMessage.writableLength`, and
  `outgoingMessage.writableObjectMode` were added to Node.js v12.9.0 via
  16e0011.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Apr 14, 2022
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 14, 2022
@rickyes rickyes added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2022
@nodejs-github-bot nodejs-github-bot merged commit 86b3191 into nodejs:master Apr 17, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 86b3191

@lpinca lpinca deleted the fix/added-info-for-outgoing-message-writable branch April 17, 2022 19:12
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
- `outgoingMessage.writableCorked` was added to Node.js v13.2.0 via
  62e15a7 and backported to Node.js v12.16.0 via db8144b.
- `outgoingMessage.writableEnded` was added to Node.js v12.9.0 via
  f9b61d2.
- `outgoingMessage.writableFinished` was added to Node.js v12.7.0 via
  06d0abe.
- `outgoingMessage.writableHighWaterMark`,
  `outgoingMessage.writableLength`, and
  `outgoingMessage.writableObjectMode` were added to Node.js v12.9.0 via
  16e0011.

PR-URL: nodejs#42737
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2022
- `outgoingMessage.writableCorked` was added to Node.js v13.2.0 via
  62e15a7 and backported to Node.js v12.16.0 via db8144b.
- `outgoingMessage.writableEnded` was added to Node.js v12.9.0 via
  f9b61d2.
- `outgoingMessage.writableFinished` was added to Node.js v12.7.0 via
  06d0abe.
- `outgoingMessage.writableHighWaterMark`,
  `outgoingMessage.writableLength`, and
  `outgoingMessage.writableObjectMode` were added to Node.js v12.9.0 via
  16e0011.

PR-URL: #42737
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@targos targos mentioned this pull request May 2, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
- `outgoingMessage.writableCorked` was added to Node.js v13.2.0 via
  62e15a7 and backported to Node.js v12.16.0 via db8144b.
- `outgoingMessage.writableEnded` was added to Node.js v12.9.0 via
  f9b61d2.
- `outgoingMessage.writableFinished` was added to Node.js v12.7.0 via
  06d0abe.
- `outgoingMessage.writableHighWaterMark`,
  `outgoingMessage.writableLength`, and
  `outgoingMessage.writableObjectMode` were added to Node.js v12.9.0 via
  16e0011.

PR-URL: #42737
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
- `outgoingMessage.writableCorked` was added to Node.js v13.2.0 via
  62e15a7 and backported to Node.js v12.16.0 via db8144b.
- `outgoingMessage.writableEnded` was added to Node.js v12.9.0 via
  f9b61d2.
- `outgoingMessage.writableFinished` was added to Node.js v12.7.0 via
  06d0abe.
- `outgoingMessage.writableHighWaterMark`,
  `outgoingMessage.writableLength`, and
  `outgoingMessage.writableObjectMode` were added to Node.js v12.9.0 via
  16e0011.

PR-URL: #42737
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
- `outgoingMessage.writableCorked` was added to Node.js v13.2.0 via
  62e15a7 and backported to Node.js v12.16.0 via db8144b.
- `outgoingMessage.writableEnded` was added to Node.js v12.9.0 via
  f9b61d2.
- `outgoingMessage.writableFinished` was added to Node.js v12.7.0 via
  06d0abe.
- `outgoingMessage.writableHighWaterMark`,
  `outgoingMessage.writableLength`, and
  `outgoingMessage.writableObjectMode` were added to Node.js v12.9.0 via
  16e0011.

PR-URL: #42737
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
- `outgoingMessage.writableCorked` was added to Node.js v13.2.0 via
  62e15a7 and backported to Node.js v12.16.0 via db8144b.
- `outgoingMessage.writableEnded` was added to Node.js v12.9.0 via
  f9b61d2.
- `outgoingMessage.writableFinished` was added to Node.js v12.7.0 via
  06d0abe.
- `outgoingMessage.writableHighWaterMark`,
  `outgoingMessage.writableLength`, and
  `outgoingMessage.writableObjectMode` were added to Node.js v12.9.0 via
  16e0011.

PR-URL: #42737
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
- `outgoingMessage.writableCorked` was added to Node.js v13.2.0 via
  62e15a793a56 and backported to Node.js v12.16.0 via db8144be3187.
- `outgoingMessage.writableEnded` was added to Node.js v12.9.0 via
  f9b61d2bc7d7.
- `outgoingMessage.writableFinished` was added to Node.js v12.7.0 via
  06d0abea0d7e.
- `outgoingMessage.writableHighWaterMark`,
  `outgoingMessage.writableLength`, and
  `outgoingMessage.writableObjectMode` were added to Node.js v12.9.0 via
  16e001112c31.

PR-URL: nodejs/node#42737
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants