-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v14.x] doc: specify flag needed for JSON modules #42736
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
esm
Issues and PRs related to the ECMAScript Modules implementation.
v14.x
labels
Apr 14, 2022
I'm opening this against |
aduh95
changed the title
doc: specify flag needed for JSON modules
[v14.x] doc: specify flag needed for JSON modules
Apr 14, 2022
aduh95
reviewed
Apr 14, 2022
aduh95
reviewed
Apr 14, 2022
aduh95
approved these changes
Apr 14, 2022
GeoffreyBooth
approved these changes
Apr 14, 2022
juanarbol
pushed a commit
that referenced
this pull request
Apr 28, 2022
PR-URL: #42736 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Thanksss! Landed in 3d3d7ed 🎉 |
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 1, 2022
PR-URL: #42736 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.