Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise data imports and node: imports sections #42734

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 14, 2022

Revise for conformance with style guide and clarity.

Revise for conformance with style guide and clarity.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Apr 14, 2022
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 14, 2022
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 14, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2022
@nodejs-github-bot nodejs-github-bot merged commit aa88e5e into nodejs:master Apr 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in aa88e5e

@Trott Trott deleted the esm-revise branch April 14, 2022 18:28
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
Revise for conformance with style guide and clarity.

PR-URL: nodejs#42734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
Revise for conformance with style guide and clarity.

PR-URL: #42734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
Revise for conformance with style guide and clarity.

PR-URL: #42734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
Revise for conformance with style guide and clarity.

PR-URL: #42734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
Revise for conformance with style guide and clarity.

PR-URL: #42734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Revise for conformance with style guide and clarity.

PR-URL: nodejs/node#42734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants