Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 10.1.124.8 #42730

Merged
merged 1 commit into from
Apr 14, 2022
Merged

deps: patch V8 to 10.1.124.8 #42730

merged 1 commit into from
Apr 14, 2022

Conversation

targos
Copy link
Member

@targos targos commented Apr 14, 2022

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 14, 2022
@targos targos added fast-track PRs that do not need to wait for 48 hours to land. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Apr 14, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 14, 2022 •
edited by VoltrexKeyva
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/43491/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4632/

@targos
Copy link
Member Author

targos commented Apr 14, 2022

@BethGriggs FYI

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43498/

@BethGriggs BethGriggs added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2022
@nodejs-github-bot nodejs-github-bot merged commit e938515 into master Apr 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in e938515

@BethGriggs BethGriggs mentioned this pull request Apr 14, 2022
Merged
@github-actions github-actions bot mentioned this pull request Apr 15, 2022
Open
16 tasks
@targos targos deleted the v8-101-8 branch April 15, 2022 08:21
This was referenced Apr 16, 2022
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Apr 20, 2022
Open
16 tasks
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@targos @xtx1130
deps: patch V8 to 10.1.124.8
8402a9c 
Refs: v8/v8@10.1.124.6...10.1.124.8

PR-URL: nodejs#42730
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @gengjiawen @richardlau @BethGriggs