Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update clang-format 1.6.0 to 1.7.0 #42723

Closed
wants to merge 1 commit into from
Closed

tools: update clang-format 1.6.0 to 1.7.0 #42723

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 13, 2022

This resolves npm audit warnings when running make format-cpp-build.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 13, 2022
RaisinTen
RaisinTen approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore -> tools as the subsystem?

@Trott
tools: update clang-format 1.6.0 to 1.7.0
7131ad4 
This resolves `npm audit` warnings when running `make format-cpp-build`.
@Trott Trott changed the title chore: update clang-format 1.6.0 to 1.7.0 tools: update clang-format 1.6.0 to 1.7.0 Apr 13, 2022
@Trott Trott closed this Apr 13, 2022
@Trott
Copy link
Member Author

Trott commented Apr 13, 2022

Uh, that was weird. I didn't close this. I must have don't something odd somewhere with the force push....

@Trott
Copy link
Member Author

Trott commented Apr 13, 2022

Moved to #42724. I was on GitPod and I'm guessing it had something to do with a shallow checkout or something like that, but
¯\(ツ)/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trott @RaisinTen @nodejs-github-bot