Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve doc for http.ServerResponse inheritance #42693

Merged
merged 1 commit into from
Apr 14, 2022
Merged

doc: improve doc for http.ServerResponse inheritance #42693

merged 1 commit into from
Apr 14, 2022

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Apr 11, 2022

Document that http.ServerResponse inherits from
http.OutgoingMessage.

@lpinca
doc: improve doc for http.ServerResponse inheritance
5968b27 
Document that `http.ServerResponse` inherits from
`http.OutgoingMessage`.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Apr 11, 2022
mcollina
mcollina approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marsonya marsonya added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 11, 2022
@marsonya marsonya added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2022
@nodejs-github-bot nodejs-github-bot merged commit e61b62b into nodejs:master Apr 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in e61b62b

@lpinca lpinca deleted the improve/doc-for-server-response-inheritance branch April 14, 2022 07:26
@BethGriggs BethGriggs mentioned this pull request Apr 14, 2022
Merged
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@lpinca @xtx1130
doc: improve doc for http.ServerResponse inheritance
5ad7ffd 
Document that `http.ServerResponse` inherits from
`http.OutgoingMessage`.

PR-URL: nodejs#42693
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: James M Snell <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@lpinca @juanarbol
doc: improve doc for http.ServerResponse inheritance
444754b 
Document that `http.ServerResponse` inherits from
`http.OutgoingMessage`.

PR-URL: #42693
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@lpinca @danielleadams
doc: improve doc for http.ServerResponse inheritance
ce4185d 
Document that `http.ServerResponse` inherits from
`http.OutgoingMessage`.

PR-URL: #42693
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
@lpinca @targos
doc: improve doc for http.ServerResponse inheritance
411c5ab 
Document that `http.ServerResponse` inherits from
`http.OutgoingMessage`.

PR-URL: #42693
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@lpinca @targos
doc: improve doc for http.ServerResponse inheritance
8067113 
Document that `http.ServerResponse` inherits from
`http.OutgoingMessage`.

PR-URL: #42693
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@lpinca @guangwong
doc: improve doc for http.ServerResponse inheritance
100f53d 
Document that `http.ServerResponse` inherits from
`http.OutgoingMessage`.

PR-URL: nodejs/node#42693
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@marsonya marsonya marsonya approved these changes

@rickyes rickyes rickyes approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@Mesteery Mesteery Mesteery approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lpinca @nodejs-github-bot @mcollina @jasnell @Trott @marsonya @rickyes @RaisinTen @Mesteery