Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls_wrap: inherit from the AsyncWrap first #4268

Closed
wants to merge 1 commit into from
Closed

tls_wrap: inherit from the AsyncWrap first #4268

wants to merge 1 commit into from

Commits on Dec 14, 2015

  1. tls_wrap: inherit from the AsyncWrap first 

    `WrapperInfo` casts pointer in JS object's internal field to
`AsyncWrap`. This approach fails miserably for `TLSWrap` because it was
inhereted from the `StreamBase` first, creating different kind of
`vtable` for the whole class.

Reorder parent classes to put `AsyncWrap` first.

Fix: nodejs#4250
    @indutny
    indutny committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    f3e77d8 View commit details
    Browse the repository at this point in the history