Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http - Updated Doc replaced request.headers with request.getHeaders() #42639

Closed
wants to merge 1 commit into from
Closed

http - Updated Doc replaced request.headers with request.getHeaders() #42639

wants to merge 1 commit into from

Conversation

kcak11
Copy link
Contributor

@kcak11 kcak11 commented Apr 7, 2022 •
edited
Loading

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Apr 7, 2022
ShogunPanda
ShogunPanda approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

VoltrexKeyva
VoltrexKeyva approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@VoltrexKeyva VoltrexKeyva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the commit message being fixed to adhere to the guidelines.

@kcak11 kcak11 changed the title Corrected the documentation to point to request.getHeaders() instead … http - Updated Doc replaced request.headers with request.getHeaders() Apr 7, 2022
@kcak11
Copy link
Contributor Author

kcak11 commented Apr 7, 2022

Will raise another pull-request with correct commit message so that tests pass.

@kcak11 kcak11 closed this Apr 7, 2022
@kcak11
Copy link
Contributor Author

kcak11 commented Apr 7, 2022

Updated pull-request with proper commit message:
#42642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kcak11 @nodejs-github-bot @ShogunPanda @VoltrexKeyva