Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix near heap limit callback #42636

Closed
wants to merge 1 commit into from
Closed

src: fix near heap limit callback #42636

wants to merge 1 commit into from

Commits on Apr 7, 2022

  1. src: fix near heap limit callback 

    - Use the allocated space size to calculate the raised heap
  limit, as that is what V8 uses to determine whether it
  should crash - previously we use the used size for the
  calculation and that was too conservative and did not
  prevent the crashes effectively enough.
- Use RequestInterrupt() to take the snapshot since we
  need to make sure that the heap limit is raised first
  before the snapshot can be taken.
    @joyeecheung
    joyeecheung committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    8b78dad View commit details
    Browse the repository at this point in the history