Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: allow numeric string for lookupService test #42596

Merged
merged 2 commits into from
Apr 12, 2022
Merged

test: allow numeric string for lookupService test #42596

merged 2 commits into from
Apr 12, 2022

Commits on Apr 4, 2022

  1. test: allow numeric string for lookupService test 

    Fixes: nodejs#42164

If the given port number isn't associated with any service name,
the `service` resolved from `dns.lookupService` can be a numeric
string representing the port number.
    @daeyeon
    daeyeon committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    3031525 View commit details
    Browse the repository at this point in the history

  2. fix: use Array.prototype.includes instead of some

    @daeyeon
    daeyeon committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    4d4292d View commit details
    Browse the repository at this point in the history