Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8: make v8.writeHeapSnapshot() error codes consistent #42577

Merged
merged 1 commit into from
Apr 5, 2022
Merged

v8: make v8.writeHeapSnapshot() error codes consistent #42577

merged 1 commit into from
Apr 5, 2022

Commits on Apr 3, 2022

  1. v8: make v8.writeHeapSnapshot() error codes consistent 

    This change makes the error codes returned by v8.writeHeapSnapshot()
consistent across all platforms by using the libuv APIs instead of
fopen(), fwrite() and fclose(). This also starts reporting potential
errors that might happen during the write operations.

Signed-off-by: Darshan Sen <[email protected]>
    @RaisinTen
    RaisinTen committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    0e8a73c View commit details
    Browse the repository at this point in the history