Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test-domain-exit-dispose-again back #4256

Commits on Dec 12, 2015

  1. test: add test-domain-exit-dispose-again back

    1c85849 "fixed"
    test-domain-exit-dispose-again by changing its logic to test that
    process.domain was cleared properly in case an error was thrown from a
    timer's callback.
    
    However, it became clear when reviewing a recent change that refactors
    lib/timers.js that it was not quite the intention of the original test.
    Thus, this change adds the original implementation of
    test-domain-exit-dispose-again back, with comments that make its
    implementation easier to understand.
    
    It also preserve the changes made by
    1c85849, but it moves them to a new
    test file named test-timers-reset-process-domain-on-throw.js.
    Julien Gilli committed Dec 12, 2015
    Configuration menu
    Copy the full SHA
    dfcbd5a View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2015

  1. Changes according to code review

    Julien Gilli committed Dec 21, 2015
    Configuration menu
    Copy the full SHA
    7bf1f08 View commit details
    Browse the repository at this point in the history