build: remove precompiled header and debug information for host builds #42538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
jasnell
approved these changes
Apr 3, 2022
targos
approved these changes
Apr 4, 2022
github-actions
bot
removed
the
request-ci
|
@targos I am not sure if the CI failures are related to this patch. |
|
Probably unrelated. I restarted CI. |
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 818284b |
juanarbol
pushed a commit
that referenced
this pull request
Apr 6, 2022
PR-URL: #42538 Refs: #42375 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
PR-URL: nodejs#42538 Refs: nodejs#42375 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42538 Refs: #42375 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42538 Refs: #42375 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #42538 Refs: #42375 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42538 Refs: #42375 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42538 Refs: nodejs/node#42375 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 21, 2022
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Nov 23, 2022
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: nodejs#45432 Refs: nodejs#42538 Refs: nodejs#42375 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to fix cross-compilation of windows/arm64 builds.
Precompiled header includes arm64 register configurations which are included for host builds and conflicts with x64 register. So they have to be removed from host builds.
Debug information is also disabled for host builds to avoid creating large libraries linker cannot handle.
Refs: #42375