Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix comments in test files #42536

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Mar 31, 2022

This pr fixes typos found in test files.

This pr fixes typos found in test files.
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 31, 2022
@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Mar 31, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 merged commit 1600869 into nodejs:master Mar 31, 2022
@aduh95
Copy link
Contributor

aduh95 commented Mar 31, 2022

Landed in 1600869

@daeyeon daeyeon deleted the master.fix-220331.Thu-10.07 branch March 31, 2022 07:02
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
This commit fixes typos found in test files.

PR-URL: nodejs#42536
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Apr 5, 2022
@juanarbol
Copy link
Member

This can not be landed in v17.x cleanly, this includes some additions added to a file (9fb7ac3#diff-5044943567bafc17ce3cc773b72184d1e238c431b4c579aefd778aba223ee4e7) in a semver major commit: 9fb7ac3

xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
This commit fixes typos found in test files.

PR-URL: nodejs#42536
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@juanarbol
Copy link
Member

This can not be landed in v17.x cleanly, this includes some additions added to a file (9fb7ac3#diff-5044943567bafc17ce3cc773b72184d1e238c431b4c579aefd778aba223ee4e7) in a semver major commit: 9fb7ac3

Same case for v16.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants