Fixed typo. Removed useless "?". #42518
Conversation
nodejs-github-bot
added
fs
There was a problem hiding this comment.
The ? here is not useless as it is ensuring buffer is not null or undefined before checking the value of .byteLength. It is part of the optional chaining operator.
Looks like tests are passing with this change, so maybe we don't need the optional chaining here? Maybe @alsoamit you meant "unused" rather than "useless"? |
AFAICT this is a user-facing function, so maybe the tests are lacking? |
It's not a user-facing function, there's no |
Refs: #42518 PR-URL: #42541 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
Refs: nodejs#42518 PR-URL: nodejs#42541 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
Refs: #42518 PR-URL: #42541 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
Refs: nodejs#42518 PR-URL: nodejs#42541 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
Refs: #42518 PR-URL: #42541 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
Refs: #42518 PR-URL: #42541 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
Refs: #42518 PR-URL: #42541 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
Refs: #42518 PR-URL: #42541 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
Refs: nodejs/node#42518 PR-URL: nodejs/node#42541 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
No description provided.