Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update GHA actions version #42498

Merged
merged 1 commit into from
Mar 30, 2022
Merged

tools: update GHA actions version #42498

merged 1 commit into from
Mar 30, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 27, 2022

//cc @nodejs/actions

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 27, 2022
@mscdex
Copy link
Contributor

mscdex commented Mar 27, 2022

Duplicate of #42460 ?

@aduh95
Copy link
Contributor Author

aduh95 commented Mar 27, 2022 •
edited
Loading

Duplicate of #42460 ?

Oh I missed this PR, thanks for linking to it. You’re right it’s overlapping but not exactly duplicate: #42460 is only updating actions/checkout from what I can see, my PR is updating other actions as well (setup-python, setup-node, etc.)

@UltiRequiem
Copy link
Contributor

Duplicate of #42460 ?

Oh I missed this PR, thanks for linking to it. You’re right it’s overlapping but not exactly duplicate: #42460 is only updating actions/checkout from what I can see, my PR is updating other actions as well (setup-python, setup-node, etc.)

Probably better to do it in separate PR, eg tools: update setup-python GHA and tools: update setup-node GHA so is easier to review.

Trott
Trott approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@Trott Trott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subsystem should be build: rather than tools: in the commit message, or at least that's what we've always usually used in the past for .github/workflows.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2022
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2022
@nodejs-github-bot nodejs-github-bot merged commit d320d45 into nodejs:master Mar 30, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in d320d45

@aduh95 aduh95 deleted the upgrade-gha branch March 30, 2022 13:41
juanarbol pushed a commit that referenced this pull request Apr 4, 2022
@aduh95 @juanarbol
tools: update GHA actions version
e59bd6f 
PR-URL: #42498
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
@aduh95 @juanarbol
tools: update GHA actions version
1670266 
PR-URL: nodejs#42498
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Apr 5, 2022
Closed
Merged
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@aduh95 @juanarbol
tools: update GHA actions version
bff9cae 
PR-URL: #42498
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@aduh95 @xtx1130
tools: update GHA actions version
68b8b01 
PR-URL: nodejs#42498
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@aduh95 @juanarbol
tools: update GHA actions version
b238396 
PR-URL: #42498
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@aduh95 @danielleadams
tools: update GHA actions version
549cdc2 
PR-URL: #42498
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
@aduh95 @targos
tools: update GHA actions version
f0ae6d8 
PR-URL: #42498
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
@aduh95 @targos
tools: update GHA actions version
7645c20 
PR-URL: #42498
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@aduh95 @targos
tools: update GHA actions version
3a2aa0a 
PR-URL: #42498
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@aduh95 @guangwong
tools: update GHA actions version
92364c5 
PR-URL: nodejs/node#42498
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aduh95 @nodejs-github-bot @mscdex @UltiRequiem @Trott @benjamingr @lpinca @Mesteery