Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: fix require('3rdparty') regression #4215

Merged
merged 1 commit into from
Dec 9, 2015
Merged

repl: fix require('3rdparty') regression #4215

merged 1 commit into from
Dec 9, 2015
+38 −0

Commits on Dec 9, 2015

  1. repl: fix require('3rdparty') regression 

    Fix module loading of third-party modules in the REPL by inheriting
module.paths from the REPL's parent module.

Commit ee72ee7 ("module,repl: remove repl require() hack") introduced
a regression where require() of modules in node_modules directories
no longer worked in the REPL (and fortunately only in the REPL.)
It turns out we didn't have test coverage for that but we do now.

Fixes: nodejs#4208
PR-URL: nodejs#4215
Reviewed-By: Roman Reiss <[email protected]>
    @bnoordhuis
    bnoordhuis committed Dec 9, 2015
    Configuration menu
    Copy the full SHA
    213ede6 View commit details
    Browse the repository at this point in the history