-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: disable empty-lines yamllint rule #42036
base: main
Are you sure you want to change the base?
Conversation
Do you have an example where the current setting is not a good fit? |
Thanks. Is there a reason to use multiple empty lines? I am no expert when it comes to YAML but it seems like there should be a way to avoid that. |
Here is a site that can explain better than me: https://yaml-multiline.info. CLOSE_MESSAGE: >
There has been no activity on this feature request
and it is being closed. If you feel closing this issue is not the
right thing to do, please leave a comment.
For more information on how the project manages
feature requests, please consult the
[feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md). becomes: There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment. For more information on how the project manages feature requests, please consult the feature request management document. |
I don't think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should disable the rule entirely because of a single case in which it is a false positive. If no option is added to yamllint, then we should probably just keep the yamllint disable rule:empty-lines
for the few valid use cases of multiple empty lines.
Refs: adrienverge/yamllint#444
Refs: #41981 (comment)