Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove eslint-disable comments from fixtures #41859

Merged
merged 1 commit into from
Feb 6, 2022
Merged

test: remove eslint-disable comments from fixtures #41859

merged 1 commit into from
Feb 6, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 5, 2022

We do not lint the fixtures code so eslint-disable comments are
superfluous.

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 5, 2022
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2022

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42383/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42386/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42392/

@Trott
test: remove eslint-disable comments from fixtures
fa05f80 
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: nodejs#41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott Trott merged commit fa05f80 into nodejs:master Feb 6, 2022
@Trott
Copy link
Member Author

Trott commented Feb 6, 2022

Landed in fa05f80

@Trott Trott deleted the fixtures-eslint branch February 6, 2022 16:27
This was referenced Feb 7, 2022
Open
Open
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@Trott @ruyadorno
test: remove eslint-disable comments from fixtures
573cafe 
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
This was referenced Feb 9, 2022
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
test: remove eslint-disable comments from fixtures
5d044e7 
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
test: remove eslint-disable comments from fixtures
7812f77 
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@Trott @danielleadams
test: remove eslint-disable comments from fixtures
3342a86 
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: nodejs#41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@Trott @danielleadams
test: remove eslint-disable comments from fixtures
7077e5b 
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: nodejs#41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@Trott @danielleadams
test: remove eslint-disable comments from fixtures
5226e35 
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
test: remove eslint-disable comments from fixtures
20ec776 
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@Mesteery Mesteery Mesteery approved these changes

Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @jasnell @lpinca @cjihrig @tniessen @Mesteery