[v14.x backport] build: set DESTCPU correctly for 'make binary' on Apple Silicon #41855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
evanlucas
pushed a commit
to evanlucas/node
that referenced
this pull request
Feb 5, 2022
PR-URL: nodejs#40147 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Backport-PR-URL: nodejs#41855
evanlucas
force-pushed
the
backport-40147-to-v14.x
branch
from
05c2a15
to
68b4391
Compare
evanlucas
requested review from
richardlau,
jasnell,
lpinca,
mhdawson and
targos
lpinca
approved these changes
Feb 23, 2022
targos
approved these changes
Feb 23, 2022
evanlucas
added
the
commit-queue
richardlau
force-pushed
the
v14.x-staging
branch
2 times, most recently
from
30ba86c
to
7f2825b
Compare
PR-URL: nodejs#40147 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Backport-PR-URL: nodejs#41855
evanlucas
force-pushed
the
backport-40147-to-v14.x
branch
from
68b4391
to
1c9ebe3
Compare
evanlucas
removed
needs-ci
This was referenced Apr 19, 2022
Merged
richardlau
approved these changes
Apr 29, 2022
juanarbol
pushed a commit
that referenced
this pull request
May 1, 2022
PR-URL: #40147 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Backport-PR-URL: #41855
|
Landed in c73ac52 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #40147
Reviewed-By: Michaël Zasso [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Michael Dawson [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Richard Lau [email protected]
This fixes building on Apple Silicon on v14.x.