Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: exclude ibm i tests until we resolve #41812

Closed
wants to merge 1 commit into from
Closed

test: exclude ibm i tests until we resolve #41812

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Feb 1, 2022

Refs: #39683

These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.

Signed-off-by: Michael Dawson [email protected]

@mhdawson
test: exclude ibm i tests until we resolve
fa8d822 
Refs: nodejs#39683

These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 1, 2022
@richardlau richardlau added the ibm i Issues and PRs related to the IBM i platform. label Feb 1, 2022
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42307/

@mhdawson
Copy link
Member Author

mhdawson commented Feb 1, 2022

Going to land based on fast track.

mhdawson added a commit that referenced this pull request Feb 1, 2022
@mhdawson
test: exclude ibm i tests until we resolve
1387bb5 
Refs: #39683

These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41812
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@mhdawson
Copy link
Member Author

mhdawson commented Feb 1, 2022

Landed in 1387bb5

@mhdawson mhdawson closed this Feb 1, 2022
@mhdawson mhdawson mentioned this pull request Feb 1, 2022
Open
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@mhdawson @ruyadorno
test: exclude ibm i tests until we resolve
ea96640 
Refs: #39683

These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41812
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
richardlau added a commit to richardlau/node-1 that referenced this pull request Feb 15, 2022
@richardlau
test: fix names of tests marked flaky on IBM i
e2db643 
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.

Refs: nodejs#41812
Refs: nodejs#39683
@richardlau richardlau mentioned this pull request Feb 15, 2022
Merged
nodejs-github-bot pushed a commit that referenced this pull request Feb 15, 2022
@richardlau
test: fix names of tests marked flaky on IBM i
bbd7cf7 
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.

Refs: #41812
Refs: #39683

PR-URL: #41984
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
bengl pushed a commit to bengl/node that referenced this pull request Feb 21, 2022
@richardlau @bengl
test: fix names of tests marked flaky on IBM i
6034944 
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.

Refs: nodejs#41812
Refs: nodejs#39683

PR-URL: nodejs#41984
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
bengl pushed a commit to bengl/node that referenced this pull request Feb 21, 2022
@richardlau @bengl
test: fix names of tests marked flaky on IBM i
702b6ca 
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.

Refs: nodejs#41812
Refs: nodejs#39683

PR-URL: nodejs#41984
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
bengl pushed a commit that referenced this pull request Feb 21, 2022
@richardlau @bengl
test: fix names of tests marked flaky on IBM i
dfed498 
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.

Refs: #41812
Refs: #39683

PR-URL: #41984
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
bengl pushed a commit that referenced this pull request Feb 22, 2022
@richardlau @bengl
test: fix names of tests marked flaky on IBM i
f8e302c 
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.

Refs: #41812
Refs: #39683

PR-URL: #41984
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@mhdawson @danielleadams
test: exclude ibm i tests until we resolve
0907c1b 
Refs: #39683

These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41812
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@mhdawson @danielleadams
test: exclude ibm i tests until we resolve
f39d1bb 
Refs: #39683

These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41812
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@mhdawson @danielleadams
test: exclude ibm i tests until we resolve
3690d34 
Refs: #39683

These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41812
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 21, 2022
@richardlau @danielleadams
test: fix names of tests marked flaky on IBM i
e5b4c53 
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.

Refs: #41812
Refs: #39683

PR-URL: #41984
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 24, 2022
@richardlau @danielleadams
test: fix names of tests marked flaky on IBM i
711e863 
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.

Refs: #41812
Refs: #39683

PR-URL: #41984
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. ibm i Issues and PRs related to the IBM i platform. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mhdawson @nodejs-github-bot @Trott @cjihrig @richardlau @VoltrexKeyva