http2: fix no response event on continue request #41739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
http2
|
Hey @ofirbarak thanks for tackling this, I am not sure the fix is quite correct - I see there are some relevant test failures? |
github-actions
bot
removed
the
request-ci
benjamingr
approved these changes
Jan 29, 2022
Linkgoron
reviewed
Jan 29, 2022
Trott
previously requested changes
Jan 30, 2022
There was a problem hiding this comment.
Welcome, @ofirbarak and thanks for this pull request as well! As with the other one, please change the start of the first commit message from lib: to http2:. Thanks!
If another collaborator wants to land this before that change, feel free to dismiss this review but please change the commit message while landing. Thanks!
added 4 commits
January 30, 2022 15:22
When sending a continue request, server response with null, it does not fires the response event type Fixes: nodejs#38258
ofirbarak
force-pushed
the
http2-null-response
branch
from
7bc8b08
to
91db9b4
Compare
ofirbarak
changed the title
ofirbarak
changed the title
|
@jasnell could you take a look before we land? |
jasnell
approved these changes
Feb 3, 2022
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/41739 ✔ Done loading data for nodejs/node/pull/41739 ----------------------------------- PR info ------------------------------------ Title http2: fix no response event on continue request (#41739) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch ofirbarak:http2-null-response -> nodejs:master Labels http2 Commits 4 - http2: fix no response event on continue request - fix liniting issues - correct the fix - simplify condition Committers 1 - ofir PR-URL: https://github.com/nodejs/node/pull/41739 Fixes: https://github.com/nodejs/node/issues/38258 Refs: https://github.com/nodejs/node/pull/38561 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41739 Fixes: https://github.com/nodejs/node/issues/38258 Refs: https://github.com/nodejs/node/pull/38561 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 29 Jan 2022 00:22:36 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41739#pullrequestreview-866996187 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41739#pullrequestreview-867008165 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41739#pullrequestreview-871911901 ⚠ GitHub cannot link the author of 'http2: fix no response event on continue request' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ⚠ GitHub cannot link the author of 'fix liniting issues' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ⚠ GitHub cannot link the author of 'correct the fix' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ⚠ GitHub cannot link the author of 'simplify condition' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-02-03T09:48:20Z: https://ci.nodejs.org/job/node-test-pull-request/42332/ - Querying data for job/node-test-pull-request/42332/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 41739 From https://github.com/nodejs/node * branch refs/pull/41739/merge -> FETCH_HEAD ✔ Fetched commits as 28989b4103d7..91db9b4d8b22 -------------------------------------------------------------------------------- [master 69c13726d0] http2: fix no response event on continue request Author: ofir Date: Sat Jan 29 02:14:00 2022 +0200 2 files changed, 98 insertions(+), 55 deletions(-) rewrite test/parallel/test-http2-compat-expect-continue.js (85%) [master a05210f0c0] fix liniting issues Author: ofir Date: Sat Jan 29 03:11:06 2022 +0200 2 files changed, 2 insertions(+), 2 deletions(-) [master 9168f2a135] correct the fix Author: ofir Date: Sat Jan 29 13:39:06 2022 +0200 2 files changed, 4 insertions(+), 4 deletions(-) [master 02e3fa3a4e] simplify condition Author: ofir Date: Sun Jan 30 15:22:04 2022 +0200 1 file changed, 1 insertion(+), 4 deletions(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8)https://github.com/nodejs/node/actions/runs/1789949374 |
nodejs-github-bot
added
the
commit-queue-failed
benjamingr
removed
the
commit-queue-failed
benjamingr
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in be6844d |
|
Congrats on your first contribution to Node core @ofirbarak 🎉 |
|
Thank you! |
VoltrexKeyva
pushed a commit
to VoltrexKeyva/node
that referenced
this pull request
Feb 3, 2022
When sending a continue request, server response with null, it does not fires the response event type Fixes: nodejs#38258 PR-URL: nodejs#41739 Refs: nodejs#38561 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Feb 5, 2022
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
When sending a continue request, server response with null, it does not fires the response event type Fixes: #38258 PR-URL: #41739 Refs: #38561 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
When sending a continue request, server response with null, it does not fires the response event type Fixes: #38258 PR-URL: #41739 Refs: #38561 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
When sending a continue request, server response with null, it does not fires the response event type Fixes: #38258 PR-URL: #41739 Refs: #38561 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
to danielleadams/node
that referenced
this pull request
Mar 4, 2022
When sending a continue request, server response with null, it does not fires the response event type Fixes: nodejs#38258 PR-URL: nodejs#41739 Refs: nodejs#38561 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
to danielleadams/node
that referenced
this pull request
Mar 4, 2022
When sending a continue request, server response with null, it does not fires the response event type Fixes: nodejs#38258 PR-URL: nodejs#41739 Refs: nodejs#38561 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 8, 2022
When sending a continue request, server response with null, it does not fires the response event type Fixes: #38258 PR-URL: #41739 Refs: #38561 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
When sending a continue request, server response with null, it does not fires the response event type Fixes: #38258 PR-URL: #41739 Refs: #38561 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending a continue request, server response with null, but it does not fires the response event type
Fixes: #38258
Ref: #38561