Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timers: improve setImmediate() performance #4169

Merged
merged 1 commit into from
Mar 18, 2016

Commits on Mar 18, 2016

  1. timers: improve setImmediate() performance

    This commit improves setImmediate() performance by moving the
    try-finally block that wraps callback execution into a separate
    function because currently v8 never tries to optimize functions
    that contain try-finally blocks.
    
    With this change, there is a ~20-40% improvement in the included
    setImmediate() depth benchmarks. The breadth benchmarks show a slight
    improvement.
    
    PR-URL: nodejs#4169
    Reviewed-By: Minwoo Jung <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    mscdex committed Mar 18, 2016
    Configuration menu
    Copy the full SHA
    089bef0 View commit details
    Browse the repository at this point in the history