-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update Mesteery email #41683
doc: update Mesteery email #41683
Conversation
@@ -649,7 +649,7 @@ maintaining the Node.js project. | |||
* [marsonya](https://github.com/marsonya) - | |||
**Akhil Marsonya** <<[email protected]>> (he/him) | |||
* [Mesteery](https://github.com/Mesteery) - | |||
**Mestery** <<mestery@pm.me>> | |||
**Mestery** <<mestery@protonmail.com>> (he/him) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a .mailmap
entry for this too so that your entry here matches your entry in AUTHORS
and so that you won't show up in AUTHORS
twice?
It should look something like this and be placed in the right place in .mailmap
alphabetically:
Mestery <[email protected]> <[email protected]>
After you add the entry, you can test it by running tools/update-authors.js
. That will update the AUTHORS file and automatically change your pm.me entry to protonmail.com. Then add that version of AUTHORS
to this PR> (It may also add new entries to the end of the AUTHORS file. You can delete those or leave them as part of this PR.)
All told, three files need to be updated: README.md
, .mailmap
, and (via the update script) AUTHORS
.
Landed in 44f8b4f |
Refs: #41683 (review) PR-URL: #41751 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#41683 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: nodejs#41683 (review) PR-URL: nodejs#41751 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #41683 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: #41683 (review) PR-URL: #41751 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #41683 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: #41683 (review) PR-URL: #41751 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #41683 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: #41683 (review) PR-URL: #41751 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #41683 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: #41683 (review) PR-URL: #41751 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
No description provided.