Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix cjs example code for process.arch #41593

Closed
wants to merge 1 commit into from
Closed

doc: fix cjs example code for process.arch #41593

wants to merge 1 commit into from

Conversation

Manduro
Copy link
Contributor

@Manduro Manduro commented Jan 19, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Jan 19, 2022
@Mesteery Mesteery added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 19, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Mesteery. Please 👍 to approve.

@Ayase-252 Ayase-252 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 19, 2022
@tniessen
Copy link
Member

Thank you @Manduro!

@tniessen
Copy link
Member

Landed in d8f6b38, thank you!

@tniessen tniessen closed this Jan 19, 2022
tniessen pushed a commit that referenced this pull request Jan 19, 2022
@Manduro @tniessen
doc: fix cjs example code for process.arch
d8f6b38 
PR-URL: #41593
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@Manduro @BethGriggs
doc: fix cjs example code for process.arch
952623d 
PR-URL: #41593
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Manduro @Linkgoron
doc: fix cjs example code for process.arch
92dda80 
PR-URL: nodejs#41593
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 26, 2022
@Manduro @danielleadams
doc: fix cjs example code for process.arch
17183d3 
PR-URL: #41593
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Manduro @danielleadams
doc: fix cjs example code for process.arch
c3321ba 
PR-URL: #41593
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Manduro @danielleadams
doc: fix cjs example code for process.arch
10320c2 
PR-URL: #41593
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@Mesteery Mesteery Mesteery approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Manduro @tniessen @cjihrig @richardlau @Ayase-252 @Mesteery @VoltrexKeyva @nodejs-github-bot