Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: remove dns.lookup and dnsPromises.lookup options type coercion #41431

Merged
merged 2 commits into from
Apr 12, 2022
Merged

dns: remove dns.lookup and dnsPromises.lookup options type coercion #41431

merged 2 commits into from
Apr 12, 2022

Commits on Apr 12, 2022

  1. net: make server.address() return an integer for family 

    `dns.lookup` options only accepts integer for `family` options,
having a string doesn't really make sense here.

PR-URL: nodejs#41431
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
    @aduh95
    aduh95 committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    3a26db9 View commit details
    Browse the repository at this point in the history

  2. dns: remove dns.lookup and dnsPromises.lookup options type coercion 

    PR-URL: nodejs#41431
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
    @aduh95
    aduh95 committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    08773e3 View commit details
    Browse the repository at this point in the history