Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix,v8: make v8.writeHeapSnapshot throw if fopen/fclose fail #41373

Merged
merged 1 commit into from
Jan 12, 2022
Merged

fix,v8: make v8.writeHeapSnapshot throw if fopen/fclose fail #41373

merged 1 commit into from
Jan 12, 2022

Commits on Jan 2, 2022

  1. v8: make writeHeapSnapshot throw if fopen fails 

    If the file fails to be written (e.g. missing permissions, no space left
on device, etc), `writeHeapSnapshot` will now throw an exception.

This commit also adds error handling for the `fclose` call, returning
false if a non-zero value was returned.

Fixes: nodejs#41346
    @kyranet
    kyranet committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    c954247 View commit details
    Browse the repository at this point in the history