doc: fix sync comment in observer example #41262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
lpinca
approved these changes
Dec 21, 2021
jasnell
approved these changes
Dec 21, 2021
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
VoltrexKeyva
approved these changes
Dec 22, 2021
HarshithaKP
approved these changes
Dec 22, 2021
|
Anything else I need to do to get this across the finish line? |
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d34fcb6 |
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41262 Refs: #41259 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Harshitha K P <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
PR-URL: #41262 Refs: #41259 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Harshitha K P <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41262 Refs: nodejs#41259 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Harshitha K P <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41262 Refs: #41259 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Harshitha K P <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates doc comment here since the PerformanceObserver callback is always called asynchronously.
Refs: #41259