lib: fix consistency of methods that emit warnings #41249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dns
kuriyosh
force-pushed
the
dns-util-consistency
branch
from
217df91 to
f6711b9
Compare
kuriyosh
force-pushed
the
dns-util-consistency
branch
from
f6711b9 to
f84132d
Compare
github-actions
bot
removed
the
request-ci
watilde
approved these changes
Jan 4, 2022
jasnell
approved these changes
Jan 17, 2022
Mesteery
approved these changes
Jan 17, 2022
Mesteery
added
the
author ready
github-actions
bot
removed
the
request-ci
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in feafea1 |
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
PR-URL: #41249 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mestery <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41249 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mestery <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 28, 2022
PR-URL: #41249 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mestery <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
PR-URL: #41249 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mestery <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
PR-URL: #41249 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mestery <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41249 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mestery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency, I refactored emitInvalidHostnameWarning method same logic as emitTypeCoercionDeprecationWarning.