Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: correct param name in JSDoc comment #41241

Merged
merged 2 commits into from
Dec 21, 2021
Merged

test: correct param name in JSDoc comment #41241

merged 2 commits into from
Dec 21, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 19, 2021

No description provided.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 19, 2021
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 19, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

aduh95
aduh95 approved these changes Dec 19, 2021
View reviewed changes
test/common/wpt.js Outdated Show resolved Hide resolved
@Trott @aduh95
Update test/common/wpt.js
19fc7bf 
Co-authored-by: Antoine du Hamel <[email protected]>
@Trott Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Dec 19, 2021
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41568/

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Dec 21, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2021
@nodejs-github-bot nodejs-github-bot merged commit 0132db0 into nodejs:master Dec 21, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 0132db0

@Trott Trott deleted the wpt-param branch December 21, 2021 18:16
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott @targos
test: correct param name in JSDoc comment
8f08328 
PR-URL: #41241
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott @danielleadams
test: correct param name in JSDoc comment
ffd829d 
PR-URL: #41241
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
test: correct param name in JSDoc comment
7ed096f 
PR-URL: nodejs#41241
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
test: correct param name in JSDoc comment
8926d95 
PR-URL: #41241
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @jasnell @aduh95