Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-crypto-keygen flaky on windows #41207

Closed
wants to merge 2 commits into from
Closed

test: mark test-crypto-keygen flaky on windows #41207

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e48d755
test: mark test-crypto-keygen slow on windows
mhdawson Dec 16, 2021
fc702d4
Update parallel.status
mhdawson Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/parallel/parallel.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ prefix parallel
test-timers-immediate-queue: PASS,FLAKY
# https://github.com/nodejs/node/issues/23277
test-worker-memory: PASS,FLAKY
# https://github.com/nodejs/node/issues/41206
test-crypto-keygen: SLOW
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking a test SLOW has no effect unless the test runner is run with --flaky-tests=skip which is not the case for Windows test builds (which run with --flaky-tests=dontcare but SLOW test are not FLAKY):

node/tools/test.py

Lines 1703 to 1704 in a257294

elif (options.flaky_tests == SKIP) and (set([SLOW, FLAKY]) & case.outcomes):
return False

See #23251 for when SLOW was introduced.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardlau thanks for pointing that out. Updated to mark as flaky instead.


[$system==linux]
# https://github.com/nodejs/node/issues/39368
Expand Down