-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mark wpt/test-user-timing test flaky #41203
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The RH team had a team day looking at helping move the CI closer to green. This is one of the flaky tests with the most reported failures and has been open since October. Marking flaky. Signed-off-by: Michael Dawson <[email protected]>
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Dec 16, 2021
lpinca
approved these changes
Dec 16, 2021
I think it makes sense to mark it flaky on all platforms. |
@lpinca updated. |
jasnell
approved these changes
Dec 17, 2021
edsadr
approved these changes
Dec 17, 2021
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 19, 2021
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 19, 2021
Commit Queue failed- Loading data for nodejs/node/pull/41203 ✔ Done loading data for nodejs/node/pull/41203 ----------------------------------- PR info ------------------------------------ Title test: mark wpt/test-user-timing test flaky (#41203) Author Michael Dawson (@mhdawson) Branch mhdawson:mark-flaky -> nodejs:master Labels test, needs-ci Commits 2 - test: mark wpt/test-user-timing test flaky - Update wpt.status Committers 2 - Michael Dawson - GitHub PR-URL: https://github.com/nodejs/node/pull/41203 Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Adrian Estrada ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41203 Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Adrian Estrada -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 16 Dec 2021 19:05:42 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41203#pullrequestreview-834530822 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41203#pullrequestreview-835346797 ✔ - Adrian Estrada (@edsadr): https://github.com/nodejs/node/pull/41203#pullrequestreview-835411926 ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1598856323 |
nodejs-github-bot
added
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Dec 19, 2021
22 tasks
21 tasks
Landed in 555e7f9 |
mhdawson
added a commit
that referenced
this pull request
Dec 22, 2021
- The RH team had a team day looking at helping move the CI closer to green. This is one of the flaky tests with the most reported failures and has been open since October. Marking flaky. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41203 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
This was referenced Dec 23, 2021
This was referenced Dec 27, 2021
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
- The RH team had a team day looking at helping move the CI closer to green. This is one of the flaky tests with the most reported failures and has been open since October. Marking flaky. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41203 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
- The RH team had a team day looking at helping move the CI closer to green. This is one of the flaky tests with the most reported failures and has been open since October. Marking flaky. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41203 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
- The RH team had a team day looking at helping move the CI closer to green. This is one of the flaky tests with the most reported failures and has been open since October. Marking flaky. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#41203 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
- The RH team had a team day looking at helping move the CI closer to green. This is one of the flaky tests with the most reported failures and has been open since October. Marking flaky. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41203 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the CI closer to green. This is one of the flaky tests
with the most reported failures and has been open
since October. Marking flaky.
Signed-off-by: Michael Dawson [email protected]