Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix checking syntax of esm module #41198

Merged
merged 1 commit into from
Dec 19, 2021
Merged

lib: fix checking syntax of esm module #41198

merged 1 commit into from
Dec 19, 2021

Conversation

Ayase-252
Copy link
Member

@Ayase-252 Ayase-252 commented Dec 16, 2021 •
edited
Loading

A internal function defaultGetFormat was changed in #37468. Update the call in check_syntax.js accordingly.

Fixes: #41189
Refs: #37468

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 16, 2021
DerekNonGeneric
DerekNonGeneric approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done — it seems like that function invocation should not have been getting destructed — pretty sure that's a good catch and the fix there.

Apologies from @nodejs/loaders (it wasn't me tho). ;)

@JakobJingleheimer
Copy link
Contributor

JakobJingleheimer commented Dec 16, 2021 •
edited
Loading

Mea culpa 😣

I did a search on the repo and all tests were passing, so I figured all was 👍

Thanks for catching

@koistya koistya mentioned this pull request Dec 16, 2021
Closed
@DerekNonGeneric DerekNonGeneric added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 17, 2021
@DerekNonGeneric DerekNonGeneric added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41541/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41544/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41551/

@DerekNonGeneric DerekNonGeneric added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2021
@nodejs-github-bot nodejs-github-bot merged commit 3f7dabd into nodejs:master Dec 19, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 3f7dabd

@github-actions github-actions bot mentioned this pull request Dec 20, 2021
Open
20 tasks
@Ayase-252 Ayase-252 deleted the fix/lib/esm-syntax-check branch December 20, 2021 05:52
This was referenced Dec 21, 2021
Open
Open
Open
Open
@JakobJingleheimer JakobJingleheimer mentioned this pull request Dec 28, 2021
Merged
9 tasks
targos pushed a commit that referenced this pull request Jan 14, 2022
@Ayase-252 @targos
lib: fix checking syntax of esm module
e457ec0 
Fixes: #41189

PR-URL: #41198
Refs: #37468
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Ayase-252 @danielleadams
lib: fix checking syntax of esm module
1122bd5 
Fixes: #41189

PR-URL: #41198
Refs: #37468
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Ayase-252 @Linkgoron
lib: fix checking syntax of esm module
75d1c4d 
Fixes: nodejs#41189

PR-URL: nodejs#41198
Refs: nodejs#37468
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@maganap maganap mentioned this pull request Jan 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Ayase-252 @danielleadams
lib: fix checking syntax of esm module
a47fc90 
Fixes: #41189

PR-URL: #41198
Refs: #37468
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node --check does not support ESM on Node.js 16
10 participants
@Ayase-252 @JakobJingleheimer @nodejs-github-bot @jasnell @lpinca @targos @cjihrig @tniessen @richardlau @DerekNonGeneric